core: avoid recomputing unnecessary coastings, which sometimes crashed #9825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9825 +/- ##
==========================================
- Coverage 37.79% 37.77% -0.02%
==========================================
Files 994 994
Lines 91192 91185 -7
Branches 1176 1174 -2
==========================================
- Hits 34468 34449 -19
- Misses 56270 56282 +12
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Erashin
approved these changes
Nov 25, 2024
The forward coasting would sometimes not intersect with the base curve, which causes some weirdness and 0-length steps. That coasting would only happen if there's no intersection with min speed limit. In that case, it's not actually necessary to compute it (it's supposed to give the same result as the backwards one). Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/fix-mareco-crash
branch
from
c25c2d5 to
5d3a2fc
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forward coasting would sometimes not intersect with the base curve, which causes some weirdness and 0-length steps.
That coasting would only happen if there's no intersection with min speed limit. In that case, it's not actually necessary to compute it (it's supposed to give the same result as the backwards one).