-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: harmonize timesstops component name in scenario #9832
Conversation
24e10b3
to
bd3401e
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9832 +/- ##
==========================================
- Coverage 38.14% 38.13% -0.02%
==========================================
Files 998 998
Lines 92134 92134
Branches 1192 1192
==========================================
- Hits 35149 35135 -14
- Misses 56529 56543 +14
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bd3401e
to
9723f76
Compare
Signed-off-by: Alice Khoudli <[email protected]>
9723f76
to
f82ad35
Compare
Seems like @Yohh 's approval didn't count as a |
I think this is because this PR was opened last week no? or maybe I'm fired... |
Turn all occurences of timeStops to timesStops
There were more occurences of timesStops than timeStops hence the change in this sense, but I'm fine with the other way too, as long as we make a single choice.