Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: harmonize timesstops component name in scenario #9832

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 22, 2024

Turn all occurences of timeStops to timesStops

There were more occurences of timesStops than timeStops hence the change in this sense, but I'm fine with the other way too, as long as we make a single choice.

@Synar Synar requested a review from a team as a code owner November 22, 2024 21:00
@Synar Synar force-pushed the ali/harmonize-timesstops-component-name branch from 24e10b3 to bd3401e Compare November 22, 2024 21:05
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 38.13%. Comparing base (1891f5b) to head (f82ad35).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/timesStops/TimesStops.tsx 0.00% 3 Missing ⚠️
front/src/modules/timesStops/TimesStopsOutput.tsx 0.00% 2 Missing ⚠️
.../modules/timesStops/hooks/useTimesStopsColumns.tsx 0.00% 2 Missing ⚠️
...src/modules/timesStops/hooks/useOutputTableData.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9832      +/-   ##
==========================================
- Coverage   38.14%   38.13%   -0.02%     
==========================================
  Files         998      998              
  Lines       92134    92134              
  Branches     1192     1192              
==========================================
- Hits        35149    35135      -14     
- Misses      56529    56543      +14     
  Partials      456      456              
Flag Coverage Δ
editoast 73.28% <ø> (-0.05%) ⬇️
front 20.15% <0.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Synar Synar requested review from RomainValls and Yohh November 26, 2024 08:59
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Synar Synar force-pushed the ali/harmonize-timesstops-component-name branch from bd3401e to 9723f76 Compare November 28, 2024 12:53
@Synar Synar requested a review from a team as a code owner November 28, 2024 12:53
@Synar Synar force-pushed the ali/harmonize-timesstops-component-name branch from 9723f76 to f82ad35 Compare November 28, 2024 13:26
@Synar Synar enabled auto-merge November 28, 2024 13:26
@Synar Synar added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@SharglutDev
Copy link
Contributor

Seems like @Yohh 's approval didn't count as a OSRD-E2E-Tests (but it still doesn't block the merge) ?

@Yohh
Copy link
Contributor

Yohh commented Nov 28, 2024

Seems like @Yohh 's approval didn't count as a OSRD-E2E-Tests (but it still doesn't block the merge) ?

I think this is because this PR was opened last week no? or maybe I'm fired...

@Synar Synar added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit 4158136 Nov 28, 2024
27 checks passed
@Synar Synar deleted the ali/harmonize-timesstops-component-name branch November 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants