Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add stdcm test generator for imported timetables #9840

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 25, 2024

This is an utilitary script used to help reproduce bugs that only seem to appear on imported timetables, by "bruteforcing" realistic requests.

Fix #8899, in a way. It doesn't generate regression tests right out of the box.

@eckter eckter requested a review from Erashin November 25, 2024 14:19
@eckter eckter requested a review from a team as a code owner November 25, 2024 14:19
@eckter eckter requested a review from shenriotpro November 25, 2024 14:19
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.21%. Comparing base (7527a8e) to head (9b8fc5e).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9840      +/-   ##
==========================================
+ Coverage   38.13%   38.21%   +0.08%     
==========================================
  Files         995      995              
  Lines       91675    91883     +208     
  Branches     1193     1189       -4     
==========================================
+ Hits        34963    35117     +154     
- Misses      56258    56312      +54     
  Partials      454      454              
Flag Coverage Δ
editoast 73.30% <ø> (+0.02%) ⬆️
front 20.23% <ø> (+0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenriotpro
Copy link
Contributor

Would it be hard to merge with the fuzzer?

@eckter
Copy link
Contributor Author

eckter commented Nov 26, 2024

Would it be hard to merge with the fuzzer?

The use is a little different as it doesn't generate regression tests and requires a prefilled timetable.

I could cram all the functions in the same file and parametrize a single command, but I don't think it would help with maintainability.

Ultimately we should take some times to refactor the whole thing entirely, it has clearly become a mess. But I don't think it has a high priority just yet.

@shenriotpro shenriotpro self-requested a review November 26, 2024 09:32
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eckter eckter added this pull request to the merge queue Nov 26, 2024
@eckter eckter removed this pull request from the merge queue due to a manual request Nov 26, 2024
This is an utilitary script used to help reproduce bugs
that only seem to appear on imported timetables,
by "bruteforcing" realistic requests.

Signed-off-by: Eloi Charpentier <[email protected]>
@eckter eckter added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit 990c8fa Nov 26, 2024
27 checks passed
@eckter eckter deleted the ech/stdcm-fuzzer branch November 26, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration-tests Work on Integration test, by nature related to different services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: improve fuzzer by including new features in the generated tests
4 participants