Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas, railjson_generator: comply to PEP 621 #9866

Merged
merged 1 commit into from
Nov 28, 2024
Merged

schemas, railjson_generator: comply to PEP 621 #9866

merged 1 commit into from
Nov 28, 2024

Conversation

woshilapin
Copy link
Contributor

This small change will help working with other tools than poetry which is not yet compatible.

With this simple change, you should be able to work with other tools like uv with the following commands. Note that since we still depends on poetry.lock for versions, we can install with poetry the dependency, but through uv which means everything is done entirely in the virtual environment.

# setup a virtual environment with python from `.python-version` (either the system one, or install one)
$ uv venv
# install `poetry` dependencies from `poetry.lock` (note: `poetry`is never installed system-wide)
$ uv tool run [email protected] install
# use `uv` like `poetry` to launch scripts
$ uv run ./some_script.py

This small change will help working with other tools than `poetry` which
is [not yet](python-poetry/poetry#9135)
compatible.

With this simple change, you should be able to work with other tools
like [uv](https://docs.astral.sh/uv/) with the following commands.
Note that since we still depends on `poetry.lock` for versions, we can
install with `poetry` the dependency, but through `uv` which means
everything is done entirely in the virtual environment.

```sh
# setup a virtual environment with python from `.python-version` (either the system one, or install one)
$ uv venv
# install `poetry` dependencies from `poetry.lock` (note: `poetry`is never installed system-wide)
$ uv tool run [email protected] install
# use `uv` like `poetry` to launch scripts
$ uv run ./some_script.py
```

Signed-off-by: Jean SIMARD <[email protected]>
@woshilapin woshilapin requested a review from a team as a code owner November 26, 2024 13:11
@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Nov 26, 2024
@woshilapin woshilapin removed the request for review from MahaliaStephan November 26, 2024 13:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.22%. Comparing base (68c3e14) to head (10d40de).
Report is 41 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9866      +/-   ##
==========================================
- Coverage   38.23%   38.22%   -0.01%     
==========================================
  Files         995      995              
  Lines       91883    91883              
  Branches     1189     1189              
==========================================
- Hits        35127    35119       -8     
- Misses      56302    56310       +8     
  Partials      454      454              
Flag Coverage Δ
editoast 73.30% <ø> (-0.03%) ⬇️
front 20.23% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woshilapin woshilapin added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit 9d2580e Nov 28, 2024
27 checks passed
@woshilapin woshilapin deleted the wsl/pep-621 branch November 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants