core: stdcm: fix post-processing when arrival time is set #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9874 +/- ##
==========================================
- Coverage 38.22% 38.19% -0.03%
==========================================
Files 995 998 +3
Lines 91910 92193 +283
Branches 1193 1192 -1
==========================================
+ Hits 35128 35212 +84
- Misses 56327 56525 +198
- Partials 455 456 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/fix-stdcm-post-processing-time
branch
2 times, most recently
from
c86e14e to
cba3bb6
Compare
Erashin
reviewed
Nov 27, 2024
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPostProcessing.kt
Outdated
Show resolved
Hide resolved
Erashin
approved these changes
Nov 27, 2024
eckter
force-pushed
the
ech/fix-stdcm-post-processing-time
branch
from
cba3bb6 to
0fe0ec3
Compare
We'd add too much delay to the departure time, resulting in inconsistencies Signed-off-by: Eloi Charpentier <[email protected]>
eckter
force-pushed
the
ech/fix-stdcm-post-processing-time
branch
from
0fe0ec3 to
a41cfd2
Compare
Erashin
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd add too much delay to the departure time, resulting in inconsistencies. Includes a regression unit test.
Fix #9872
Helps with #9023 as well, but it still happens, just much less often