Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix rs image blinking when changing in stdcm #9875

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

theocrsb
Copy link
Contributor

closes #9828

@theocrsb theocrsb requested a review from a team as a code owner November 27, 2024 15:17
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 38.20%. Comparing base (e1bb669) to head (96440b4).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...ockSelector/useStoreDataForRollingStockSelector.ts 0.00% 8 Missing ⚠️
...dules/rollingStock/components/RollingStock2Img.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9875      +/-   ##
==========================================
- Coverage   38.22%   38.20%   -0.02%     
==========================================
  Files         995      995              
  Lines       91893    91912      +19     
  Branches     1189     1193       +4     
==========================================
- Hits        35127    35117      -10     
- Misses      56312    56340      +28     
- Partials      454      455       +1     
Flag Coverage Δ
editoast 73.30% <ø> (-0.03%) ⬇️
front 20.19% <0.00%> (-0.04%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Lgtm (tested)

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@theocrsb theocrsb added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit deac2f4 Nov 28, 2024
27 checks passed
@theocrsb theocrsb deleted the tce/front/fix-rs-image-blinking branch November 28, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rolling stock image blinking when changing
4 participants