Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: consist compute gamma #9876

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Nov 27, 2024

fix #9806
Add consist compute gamma

@Wadjetz Wadjetz self-assigned this Nov 27, 2024
@Wadjetz Wadjetz added area:editoast Work on Editoast Service module:stdcm Short-Term DCM labels Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (7a0728b) to head (ba0d378).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #9876   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files        1047     1047           
  Lines      105152   105170   +18     
  Branches      756      756           
=======================================
+ Hits        83988    84003   +15     
- Misses      21123    21126    +3     
  Partials       41       41           
Flag Coverage Δ
editoast 73.41% <100.00%> (+<0.01%) ⬆️
front 89.35% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast/consist-compute-gamma branch 3 times, most recently from ffc6a80 to c510df8 Compare December 3, 2024 11:03
@Wadjetz Wadjetz requested review from woshilapin and axrolld December 3, 2024 11:22
@Wadjetz Wadjetz marked this pull request as ready for review December 3, 2024 11:22
@Wadjetz Wadjetz requested a review from a team as a code owner December 3, 2024 11:22
@Wadjetz Wadjetz requested a review from hamz2a December 3, 2024 11:22
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Wadjetz Wadjetz force-pushed the ebe/editoast/consist-compute-gamma branch from c510df8 to 737cf5b Compare December 3, 2024 13:28
Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to make sure i got this right in the test. Otherwise the implementation looks good to me !

@Wadjetz Wadjetz force-pushed the ebe/editoast/consist-compute-gamma branch from 737cf5b to 2caaff8 Compare December 4, 2024 10:33
@Wadjetz Wadjetz requested a review from axrolld December 4, 2024 10:36
@Wadjetz Wadjetz force-pushed the ebe/editoast/consist-compute-gamma branch from 2caaff8 to 98296b0 Compare December 4, 2024 13:56
Signed-off-by: Egor Berezovskiy <[email protected]>
@Wadjetz Wadjetz force-pushed the ebe/editoast/consist-compute-gamma branch from 98296b0 to ba0d378 Compare December 5, 2024 16:29
@Wadjetz Wadjetz added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit 7d5c7ea Dec 5, 2024
27 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast/consist-compute-gamma branch December 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: deceleration rate doesn't change when changing towed rolling stock
5 participants