-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: consist compute gamma #9876
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9876 +/- ##
=======================================
Coverage 79.87% 79.87%
=======================================
Files 1047 1047
Lines 105152 105170 +18
Branches 756 756
=======================================
+ Hits 83988 84003 +15
- Misses 21123 21126 +3
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ffc6a80
to
c510df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
c510df8
to
737cf5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments to make sure i got this right in the test. Otherwise the implementation looks good to me !
737cf5b
to
2caaff8
Compare
2caaff8
to
98296b0
Compare
Signed-off-by: Egor Berezovskiy <[email protected]>
98296b0
to
ba0d378
Compare
fix #9806
Add consist compute gamma