Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: make rs label shorter #9879

Merged
merged 1 commit into from
Nov 28, 2024
Merged

front: make rs label shorter #9879

merged 1 commit into from
Nov 28, 2024

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Nov 27, 2024

close #9358

@kmer2016 kmer2016 requested a review from a team as a code owner November 27, 2024 15:38
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 27, 2024
@kmer2016 kmer2016 requested review from clarani and Akctarus November 27, 2024 15:38
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.20%. Comparing base (ab6cdbb) to head (d6b7462).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
...ations/stdcm/components/StdcmForm/StdcmConsist.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9879      +/-   ##
==========================================
- Coverage   38.22%   38.20%   -0.02%     
==========================================
  Files         995      995              
  Lines       91910    91899      -11     
  Branches     1193     1193              
==========================================
- Hits        35128    35114      -14     
- Misses      56327    56330       +3     
  Partials      455      455              
Flag Coverage Δ
editoast 73.29% <ø> (-0.05%) ⬇️
front 20.20% <0.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic's right and i saw what it looked like, it's great ! Thanks 😁

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Can you squash your commits ?

@kmer2016 kmer2016 force-pushed the cnh/rs-labels-shorter branch from 6acdf5a to d6b7462 Compare November 28, 2024 10:25
@kmer2016 kmer2016 enabled auto-merge November 28, 2024 10:26
@kmer2016 kmer2016 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit 2ccaf91 Nov 28, 2024
27 checks passed
@kmer2016 kmer2016 deleted the cnh/rs-labels-shorter branch November 28, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: make rolling stock labels shorter
5 participants