-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: make rs label shorter #9879
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9879 +/- ##
==========================================
- Coverage 38.22% 38.20% -0.02%
==========================================
Files 995 995
Lines 91910 91899 -11
Branches 1193 1193
==========================================
- Hits 35128 35114 -14
- Misses 56327 56330 +3
Partials 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic's right and i saw what it looked like, it's great ! Thanks 😁
front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅ Can you squash your commits ?
Signed-off-by: nncluzu <[email protected]>
6acdf5a
to
d6b7462
Compare
close #9358