-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: renaming in lmr #9880
front: renaming in lmr #9880
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9880 +/- ##
==========================================
- Coverage 80.06% 80.05% -0.02%
==========================================
Files 1050 1050
Lines 105421 105431 +10
Branches 758 758
==========================================
- Hits 84409 84403 -6
- Misses 20971 20987 +16
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for your proposals, @SergeCroise :) However, @Caracol3 is just following the text as it is in the mockup (see the last screen in the issue description). The way we use some words in the docs and when we display them to the user can differ regarding the context of where we use them. We can keep that in mind to maybe update the docs later :) |
front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmForm/StdcmOrigin.tsx
Outdated
Show resolved
Hide resolved
bc3fe17
to
5f9c84e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, thank you for these changes :)
There is one comment remaining, you can close it after fixing it.
5f9c84e
to
bb737dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missclick
7bb63f6
to
af198e0
Compare
- adjusting test logic after stdcm changes Signed-off-by: Mathieu <[email protected]>
af198e0
to
9a41ac3
Compare
close #9681