Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: renaming in lmr #9880

Merged
merged 1 commit into from
Dec 12, 2024
Merged

front: renaming in lmr #9880

merged 1 commit into from
Dec 12, 2024

Conversation

Caracol3
Copy link
Contributor

@Caracol3 Caracol3 commented Nov 27, 2024

  • To get the 'no capacity' message, try a consist with 30KM/h maxspeed
  • For the 'technical issue' i randomly manage to get it but can't reproduce it now so its hard to test.

close #9681

@Caracol3 Caracol3 added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM labels Nov 27, 2024
@Caracol3 Caracol3 requested a review from a team as a code owner November 27, 2024 15:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (1869fad) to head (9a41ac3).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9880      +/-   ##
==========================================
- Coverage   80.06%   80.05%   -0.02%     
==========================================
  Files        1050     1050              
  Lines      105421   105431      +10     
  Branches      758      758              
==========================================
- Hits        84409    84403       -6     
- Misses      20971    20987      +16     
  Partials       41       41              
Flag Coverage Δ
editoast 74.21% <ø> (-0.06%) ⬇️
front 89.25% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev
Copy link
Contributor

SharglutDev commented Nov 28, 2024

Thank you for your proposals, @SergeCroise :)

However, @Caracol3 is just following the text as it is in the mockup (see the last screen in the issue description). The way we use some words in the docs and when we display them to the user can differ regarding the context of where we use them. We can keep that in mind to maybe update the docs later :)

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-renamings branch from bc3fe17 to 5f9c84e Compare December 5, 2024 13:37
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you for these changes :)

There is one comment remaining, you can close it after fixing it.

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-renamings branch from 5f9c84e to bb737dc Compare December 9, 2024 14:08
@Caracol3 Caracol3 requested a review from a team as a code owner December 10, 2024 15:21
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missclick

@Caracol3 Caracol3 force-pushed the mcy/front-lmr-renamings branch from 7bb63f6 to af198e0 Compare December 12, 2024 12:48
- adjusting test logic after stdcm changes

Signed-off-by: Mathieu <[email protected]>
@Caracol3 Caracol3 force-pushed the mcy/front-lmr-renamings branch from af198e0 to 9a41ac3 Compare December 12, 2024 13:33
@Caracol3 Caracol3 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into dev with commit fe3b339 Dec 12, 2024
27 checks passed
@Caracol3 Caracol3 deleted the mcy/front-lmr-renamings branch December 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmr: front: a few renamings
6 participants