Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stdcm path buttons clickable across the entire element #9894

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

achrafmohye
Copy link
Contributor

Closes #9504

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 28, 2024
@achrafmohye achrafmohye changed the title front: make add button clickable across the entire element front: make stdcm path buttons clickable across the entire element Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (ced78b4) to head (632c54f).
Report is 39 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #9894       +/-   ##
===========================================
+ Coverage   38.19%   79.83%   +41.63%     
===========================================
  Files         998     1048       +50     
  Lines       92204   105058    +12854     
  Branches     1192      756      -436     
===========================================
+ Hits        35220    83870    +48650     
+ Misses      56528    21147    -35381     
+ Partials      456       41      -415     
Flag Coverage Δ
editoast 73.34% <ø> (-0.05%) ⬇️
front 89.33% <100.00%> (+69.17%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achrafmohye achrafmohye marked this pull request as ready for review November 29, 2024 13:27
@achrafmohye achrafmohye requested a review from a team as a code owner November 29, 2024 13:27
@achrafmohye achrafmohye changed the title front: make stdcm path buttons clickable across the entire element Make stdcm path buttons clickable across the entire element Dec 3, 2024
@achrafmohye achrafmohye force-pushed the ame/clickable-add-intermediate-op-button branch from a82a6d8 to 6646f15 Compare December 3, 2024 11:10
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

@achrafmohye achrafmohye enabled auto-merge December 3, 2024 12:36
@achrafmohye achrafmohye disabled auto-merge December 4, 2024 10:05
@achrafmohye achrafmohye enabled auto-merge December 4, 2024 10:08
@achrafmohye achrafmohye force-pushed the ame/clickable-add-intermediate-op-button branch from 6646f15 to 45d0c85 Compare December 4, 2024 12:19
@achrafmohye achrafmohye force-pushed the ame/clickable-add-intermediate-op-button branch from 45d0c85 to 632c54f Compare December 4, 2024 16:31
@achrafmohye achrafmohye requested a review from a team as a code owner December 4, 2024 16:31
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e tests

@achrafmohye achrafmohye added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit 2b03522 Dec 5, 2024
27 checks passed
@achrafmohye achrafmohye deleted the ame/clickable-add-intermediate-op-button branch December 5, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Add an intermediate OP button clickable everywhere
5 participants