-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: match the width and spacing of the results table to the mockup #9904
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9904 +/- ##
==========================================
- Coverage 79.88% 79.86% -0.02%
==========================================
Files 1048 1048
Lines 105232 105232
Branches 756 756
==========================================
- Hits 84061 84048 -13
- Misses 21130 21143 +13
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d10b2e3
to
c4cdecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have 30px of padding-left on the map, I should have 32px according to the mockup. The rest of the code is fine for me ✅
bacd0e9
to
f377605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Signed-off-by: theocrsb <[email protected]>
bcb6ede
to
f4e9295
Compare
closes #9886