Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: match the width and spacing of the results table to the mockup #9904

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

theocrsb
Copy link
Contributor

closes #9886

@theocrsb theocrsb requested review from clarani and Akctarus November 29, 2024 14:24
@theocrsb theocrsb requested a review from a team as a code owner November 29, 2024 14:24
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (50a599e) to head (f4e9295).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9904      +/-   ##
==========================================
- Coverage   79.88%   79.86%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105232   105232              
  Branches      756      756              
==========================================
- Hits        84061    84048      -13     
- Misses      21130    21143      +13     
  Partials       41       41              
Flag Coverage Δ
editoast 73.41% <ø> (-0.05%) ⬇️
front 89.35% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/stdcm/result-table-matching-mockup branch 2 times, most recently from d10b2e3 to c4cdecb Compare December 2, 2024 14:39
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have 30px of padding-left on the map, I should have 32px according to the mockup. The rest of the code is fine for me ✅

@theocrsb theocrsb force-pushed the tce/front/stdcm/result-table-matching-mockup branch 2 times, most recently from bacd0e9 to f377605 Compare December 5, 2024 15:11
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theocrsb theocrsb force-pushed the tce/front/stdcm/result-table-matching-mockup branch from bcb6ede to f4e9295 Compare December 5, 2024 19:59
@theocrsb theocrsb enabled auto-merge December 5, 2024 19:59
@theocrsb theocrsb added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit eec04ff Dec 5, 2024
27 checks passed
@theocrsb theocrsb deleted the tce/front/stdcm/result-table-matching-mockup branch December 5, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stdcm results table width no matching the mockup
4 participants