Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix linked path button clickable if retained simulation #9905

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

SharglutDev
Copy link
Contributor

Remove the unnecessary div wrapper for the card

fix #9807

@SharglutDev SharglutDev requested a review from a team as a code owner November 29, 2024 14:28
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.18%. Comparing base (83934dc) to head (2a3caa1).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...dcm/components/StdcmForm/StdcmLinkedPathSearch.tsx 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9905      +/-   ##
==========================================
- Coverage   38.20%   38.18%   -0.02%     
==========================================
  Files         998      998              
  Lines       92197    92197              
  Branches     1192     1192              
==========================================
- Hits        35223    35207      -16     
- Misses      56518    56534      +16     
  Partials      456      456              
Flag Coverage Δ
editoast 73.35% <ø> (-0.06%) ⬇️
front 20.16% <0.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Math-R
Copy link
Contributor

Math-R commented Dec 1, 2024

Lgtm ✅

@SharglutDev SharglutDev added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@SharglutDev SharglutDev force-pushed the pfn/front/fix-linked-path-clickable branch from 16d19d9 to b0d7cc9 Compare December 3, 2024 08:16
@SharglutDev SharglutDev enabled auto-merge December 3, 2024 08:16
Remove the unnecessary div wrapper for the card

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the pfn/front/fix-linked-path-clickable branch from b0d7cc9 to 2a3caa1 Compare December 3, 2024 09:41
@SharglutDev SharglutDev added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit d529bf2 Dec 3, 2024
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-linked-path-clickable branch December 3, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: I can still interact with linked path buttons after downloading the simulation sheet
5 participants