-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider #9907
Slider #9907
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9907 +/- ##
==========================================
- Coverage 81.62% 81.62% -0.01%
==========================================
Files 1063 1063
Lines 105400 105429 +29
Branches 722 722
==========================================
+ Hits 86035 86057 +22
- Misses 19324 19331 +7
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2bc8a57
to
fcc21dc
Compare
9b7fd35
to
6ad1af5
Compare
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
6ad1af5
to
d3ce176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Some UI issues
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
front/src/styles/scss/common/components/_manchetteWithSpaceTimeChart.scss
Outdated
Show resolved
Hide resolved
ca3bf88
to
892da7c
Compare
e52304d
to
ac0a1ab
Compare
Signed-off-by: Valentin Chanas <[email protected]>
ac0a1ab
to
d1b1f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job :)
closes #9723
Requires OpenRailAssociation/osrd-ui#805 + release to be merged ✔️