Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix simulation sheet and csv button style #9912

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Dec 2, 2024

@Akctarus Akctarus requested a review from a team as a code owner December 2, 2024 14:10
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 2, 2024
@Akctarus Akctarus requested review from Math-R and removed request for theocrsb December 2, 2024 14:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (52ef1ae) to head (7a82ddf).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9912      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105062   105060       -2     
  Branches      756      756              
==========================================
- Hits        83887    83873      -14     
- Misses      21134    21146      +12     
  Partials       41       41              
Flag Coverage Δ
editoast 73.34% <ø> (-0.05%) ⬇️
front 89.33% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/fix-simulation-sheet-button-spacing branch from 6169ded to c2d54a5 Compare December 2, 2024 14:20
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested :)

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons are 32 px on sketch, but 40px on app

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks !

@Akctarus Akctarus force-pushed the tmn/front/fix-simulation-sheet-button-spacing branch from 0105279 to d22ec4a Compare December 4, 2024 16:21
@Akctarus Akctarus enabled auto-merge December 4, 2024 16:21
@Akctarus Akctarus force-pushed the tmn/front/fix-simulation-sheet-button-spacing branch from 611b643 to 7a82ddf Compare December 4, 2024 16:30
@Akctarus Akctarus added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 908d2aa Dec 4, 2024
27 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-simulation-sheet-button-spacing branch December 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong simulation sheet and results table spacing
5 participants