-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix nge import when there is only one step #9914
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9914 +/- ##
==========================================
- Coverage 38.19% 38.18% -0.02%
==========================================
Files 998 997 -1
Lines 92197 92196 -1
Branches 1192 1192
==========================================
- Hits 35219 35202 -17
- Misses 56522 56538 +16
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/applications/operationalStudies/components/MacroEditor/osrdToNge.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0c8842d
to
9107b95
Compare
Signed-off-by: romainvalls <[email protected]>
9107b95
to
f266678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
closes #9610
When importing a train, it can happen that the train only has 1 step, which was resulting in the origin and destination being the same step.
We check the length of the steps, if it's less than 2, we skip.