Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix nge import when there is only one step #9914

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

RomainValls
Copy link
Contributor

closes #9610

When importing a train, it can happen that the train only has 1 step, which was resulting in the origin and destination being the same step.
We check the length of the steps, if it's less than 2, we skip.

@RomainValls RomainValls self-assigned this Dec 2, 2024
@RomainValls RomainValls requested a review from a team as a code owner December 2, 2024 16:31
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.18%. Comparing base (c98d385) to head (f266678).
Report is 32 commits behind head on dev.

Files with missing lines Patch % Lines
...ationalStudies/components/MacroEditor/osrdToNge.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9914      +/-   ##
==========================================
- Coverage   38.19%   38.18%   -0.02%     
==========================================
  Files         998      997       -1     
  Lines       92197    92196       -1     
  Branches     1192     1192              
==========================================
- Hits        35219    35202      -17     
- Misses      56522    56538      +16     
  Partials      456      456              
Flag Coverage Δ
editoast 73.37% <ø> (-0.03%) ⬇️
front 20.15% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RomainValls RomainValls force-pushed the rvs/front-fix-nge-import-when-one-step-only branch from 0c8842d to 9107b95 Compare December 3, 2024 10:08
@RomainValls RomainValls force-pushed the rvs/front-fix-nge-import-when-one-step-only branch from 9107b95 to f266678 Compare December 3, 2024 10:09
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@RomainValls RomainValls added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit 52c374b Dec 5, 2024
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-nge-import-when-one-step-only branch December 5, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro mode - getSourceNode error
4 participants