Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use physics path in etcs braking simulator #9937

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Dec 4, 2024

PhysicsPath gives access to gradient AND can be accessed in this part of the code.

@Erashin Erashin requested a review from a team as a code owner December 4, 2024 09:07
@Erashin Erashin requested review from Khoyo and eckter December 4, 2024 09:07
@github-actions github-actions bot added the area:core Work on Core Service label Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.19%. Comparing base (02ccfc8) to head (3d0485e).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9937      +/-   ##
==========================================
- Coverage   38.21%   38.19%   -0.02%     
==========================================
  Files         992      992              
  Lines       92158    92158              
  Branches     1186     1186              
==========================================
- Hits        35221    35203      -18     
- Misses      56486    56504      +18     
  Partials      451      451              
Flag Coverage Δ
editoast 73.33% <ø> (-0.06%) ⬇️
front 20.18% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 6687e44 Dec 4, 2024
27 checks passed
@Erashin Erashin deleted the alch/core/etcs_use_physics_path branch December 4, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants