front: fix lazy loading for rolling stock images #9939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theocrsb
approved these changes
Dec 4, 2024
We were unconditionally fetching the rolling stock image via getDocument(). Instead, side-step getDocument() entirely, and directly use the document URL as the image source. That way, the loading="lazy" attribute can be used and the image is only fetched if it's visible. The deleted comment is wrong: authentication is required, but is performed via a cookie. Cookies are always sent for same-origin image requests. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/lazy-rolling-stock-img
branch
from
7386777 to
e3077ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unconditionally fetching the rolling stock image via getDocument(). Instead, side-step getDocument() entirely, and directly use the document URL as the image source. That way, the loading="lazy" attribute can be used and the image is only fetched if it's visible.
The deleted comment is wrong: authentication is required, but is performed via a cookie. Cookies are always sent for same-origin image requests.