Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: etcs: use the braking curves in the simulation #9941

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 4, 2024

Fix #9705

Doesn't use the new data yet, but there's clear entry points

@github-actions github-actions bot added the area:core Work on Core Service label Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (5d127e0) to head (5d17c86).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9941      +/-   ##
==========================================
- Coverage   79.81%   79.79%   -0.02%     
==========================================
  Files        1052     1052              
  Lines      105444   105444              
  Branches      727      727              
==========================================
- Hits        84155    84140      -15     
- Misses      21247    21262      +15     
  Partials       42       42              
Flag Coverage Δ
editoast 73.69% <ø> (-0.05%) ⬇️
front 89.13% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/etcs-simulation branch from c17924e to b6e9bf7 Compare December 4, 2024 13:11
@eckter eckter requested review from Erashin and bougue-pe December 4, 2024 13:14
@eckter eckter force-pushed the ech/etcs-simulation branch 2 times, most recently from e89e729 to 6c32fe5 Compare December 5, 2024 13:40
@eckter eckter marked this pull request as ready for review December 6, 2024 09:27
@eckter eckter requested a review from a team as a code owner December 6, 2024 09:27
@eckter eckter requested a review from Erashin December 6, 2024 09:27
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no major comment, thank you! 👍

@eckter eckter force-pushed the ech/etcs-simulation branch 2 times, most recently from 5afa80e to 6c3c2bf Compare December 12, 2024 13:09
@eckter eckter requested a review from bougue-pe December 12, 2024 14:05
@eckter eckter force-pushed the ech/etcs-simulation branch from 652075d to a8f255f Compare December 12, 2024 14:57
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details below, good job.

@eckter eckter force-pushed the ech/etcs-simulation branch 2 times, most recently from e899ef4 to 30ce4de Compare December 13, 2024 13:46
@eckter eckter force-pushed the ech/etcs-simulation branch from 30ce4de to 5d17c86 Compare December 17, 2024 08:54
@eckter eckter added this pull request to the merge queue Dec 17, 2024
Merged via the queue into dev with commit df3de96 Dec 17, 2024
27 checks passed
@eckter eckter deleted the ech/etcs-simulation branch December 17, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: plug ETCS module into core
4 participants