-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: etcs: use the braking curves in the simulation #9941
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9941 +/- ##
==========================================
- Coverage 79.81% 79.79% -0.02%
==========================================
Files 1052 1052
Lines 105444 105444
Branches 727 727
==========================================
- Hits 84155 84140 -15
- Misses 21247 21262 +15
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c17924e
to
b6e9bf7
Compare
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/EnvelopeSimContext.kt
Show resolved
Hide resolved
e89e729
to
6c32fe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, no major comment, thank you! 👍
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/EnvelopeSimContext.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/EnvelopeSimContext.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/EnvelopeSimContext.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/pipelines/MaxSpeedEnvelope.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/pipelines/MaxSpeedEnvelope.kt
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/etcsContextBuilder.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/etcsContextBuilder.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/standalone_sim/etcsContextBuilder.kt
Outdated
Show resolved
Hide resolved
5afa80e
to
6c3c2bf
Compare
652075d
to
a8f255f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details below, good job.
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/EnvelopeSimContext.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/pipelines/MaxSpeedEnvelope.kt
Outdated
Show resolved
Hide resolved
e899ef4
to
30ce4de
Compare
Signed-off-by: Eloi Charpentier <[email protected]>
Signed-off-by: Eloi Charpentier <[email protected]>
30ce4de
to
5d17c86
Compare
Fix #9705
Doesn't use the new data yet, but there's clear entry points