Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: bump nge version to 2.9.11 #9943

Merged
merged 1 commit into from
Dec 4, 2024
Merged

front: bump nge version to 2.9.11 #9943

merged 1 commit into from
Dec 4, 2024

Conversation

louisgreiner
Copy link
Contributor

@louisgreiner louisgreiner commented Dec 4, 2024 •
edited
Loading

Bumps to 2.9.11

Integrates a fix from fork

@louisgreiner louisgreiner requested a review from a team as a code owner December 4, 2024 10:46
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 4, 2024
@louisgreiner louisgreiner requested review from Yohh and clarani December 4, 2024 10:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (52ef1ae) to head (fa32f0c).
Report is 6 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9943      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105062   105062              
  Branches      756      756              
==========================================
- Hits        83887    83873      -14     
- Misses      21134    21148      +14     
  Partials       41       41
Flag Coverage Δ
editoast 73.34% <ø> (-0.05%) ⬇️
front 89.33% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yohh
Yohh approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget sign-off

emersion
emersion approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note, this will conflict with #9169

emersion
emersion requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json file has not been updated. You need to run npm install to update it.

@louisgreiner louisgreiner requested a review from emersion December 4, 2024 14:21
emersion
emersion approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

clarani
clarani approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@louisgreiner louisgreiner added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit d9369b0 Dec 4, 2024
27 checks passed
@louisgreiner louisgreiner deleted the lgr/bump-nge-2.9.11 branch December 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

@Yohh Yohh Yohh approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@louisgreiner @codecov-commenter @emersion @Yohh @clarani