Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: drop StdcmResultsOperationalPointsList type #9955

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Dec 5, 2024

This just adds an unnecessary indirection. Directly use an array to make it clear that we manipulate one (as opposed to an object).

This just adds an unnecessary indirection. Directly use an array
to make it clear that we manipulate one (as opposed to an object).

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested a review from a team as a code owner December 5, 2024 09:55
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 5, 2024
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emersion emersion added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@emersion emersion added this pull request to the merge queue Dec 10, 2024
Merged via the queue into dev with commit 950c4ac Dec 10, 2024
27 checks passed
@emersion emersion deleted the emr/drop-stdcm-op-list-type branch December 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants