front: fix simulation results width on wide screen

[Yohh]

close #9959

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.84%. Comparing base (419a315) to head (d88d3e1).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9960      +/-   ##
==========================================
- Coverage   79.85%   79.84%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105046   105046              
  Branches      756      756              
==========================================
- Hits        83883    83869      -14     
- Misses      21122    21136      +14     
  Partials       41       41              

Flag	Coverage Δ
editoast	73.34% <ø> (-0.05%)	⬇️
front	89.34% <ø> (ø)
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yohh]

NB: I m not sure that the max-width is really usefull at all, even in lower resolutions

[SharglutDev]

NB: I m not sure that the max-width is really usefull at all, even in lower resolutions

Probably. Doesn't it achieve the same result if you remove max-width totally ?

[Yohh]

NB: I m not sure that the max-width is really usefull at all, even in lower resolutions

Probably. Doesn't it achieve the same result if you remove max-width totally ?

it releases the col classes, so the width fit responsively, that seems much better to me, I added the media query only because I thought it was a mockup criteria

in fact, combining col and min/max-width seems to lack consistence

[SharglutDev]

Totally missread the issue. I thought we want to stretch the results, not the sidebar. Your solution seems fine to me.

We should probably get rid off the cols when we work more on the responsive design.

[Yohh]

on the contrary, cols are more responsive than using px, if I remove max-width and min-width totally the behavior seems fine:

Screencast.From.2024-12-05.14-23-05.mp4

[SharglutDev]

on the contrary, cols are more responsive than using px, if I remove max-width and min-width totally the behavior seems fine:
Screencast.From.2024-12-05.14-23-05.mp4

Yes but as you mentioned, the mockup specifies that the default sidemenu width should be 432px

[Yohh]

Yes but as you mentioned, the mockup specifies that the default sidemenu width should be 432px

ok go for it

[Caracol3]

I would also tend to prefer the use of col in the application. I find it more responsive. Though, for pixel-perfect concerns, I understand that pixels are used, but the question might be whether Thibaut is familiar with using col. If not, maybe it’s up to us to adapt the design by converting pixels to columns and get it validated by Thibaut afterward.

[Caracol3]

lgtm (tested)

[SharglutDev]

I would also tend to prefer the use of col in the application. I find it more responsive. Though, for pixel-perfect concerns, I understand that pixels are used, but the question might be whether Thibaut is familiar with using col. If not, maybe it’s up to us to adapt the design by converting pixels to columns and get it validated by Thibaut afterward.

We totally should have a discussion with him next time. I added it in the discussions list for next front meeting.