Fix accents support in x-remote-user-name
#9986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Valais <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9986 +/- ##
==========================================
+ Coverage 79.84% 79.87% +0.02%
==========================================
Files 1048 1048
Lines 105058 105241 +183
Branches 756 756
==========================================
+ Hits 83881 84058 +177
- Misses 21136 21142 +6
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
flomonster
changed the title
x-remote-user-name
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
woshilapin
reviewed
Dec 10, 2024
| @@ -201,14 +202,12 @@ async fn authenticate( | |||
| } | |||
| return Ok(Authentication::Unauthenticated); | |||
| }; | |||
| let identity = identity | |||
| .to_str() | |||
| let identity = str::from_utf8(identity.as_bytes()) | |||
| .expect("unexpected non-ascii characters in x-remote-user-identity"); | |||
There was a problem hiding this comment.
Suggested change
| .expect("unexpected non-ascii characters in x-remote-user-identity"); | |
| .expect("unexpected non-utf8 characters in x-remote-user-identity"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.