Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSRD stage 2 #141

Merged
merged 2 commits into from
Feb 27, 2025
Merged

OSRD stage 2 #141

merged 2 commits into from
Feb 27, 2025

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Sep 16, 2024

Feedback:

  • I don't know if editing the project_proposals/osrd.md file is the right thing to do for this request.
  • The first three criteria are very similar. At least the only thing to fill in as a project is the link to the repository pulses.
  • Not sure it was the best way to proof the usage of REUSE and DCO
  • There are no criteria for the openness of communication channels with contributors. The fact that OSRD has a matrix server accessible to all makes it easier to integrate contributors from outside SNCF.
  • Requiring projects to have dependencies security alerts and secret scanning alerts seems reasonable for stage 2 (it's a small proof of maturity).

@cornelius
Copy link
Member

From yesterday's TC meeting:

  • I don't know if editing the project_proposals/osrd.md file is the right thing to do for this request.

We will provide a separate questionnaire, so that the stages are separated and there is no confusion about what to add when and where.

  • The first three criteria are very similar. At least the only thing to fill in as a project is the link to the repository pulses.

We will keep this relatively free-form. Adding an explanation and links to metrics such as the repo pulse is probably good
enough as a base for the evaluation for now.

  • Not sure it was the best way to proof the usage of REUSE and DCO

We will add more details in the questionnaire (which is still to be created as a separate file).

  • There are no criteria for the openness of communication channels with contributors. The fact that OSRD has a matrix server accessible to all makes it easier to integrate contributors from outside SNCF.

To be documented in more detail.

  • Requiring projects to have dependencies security alerts and secret scanning alerts seems reasonable for stage 2 (it's a small proof of maturity).

Good point, should be added.

@schalbts
Copy link
Contributor

After review at the last TC meeting and browsing through again today, it looks good to me.

@flomonster flomonster changed the title osrd stage 2 OSRD stage 2 Feb 27, 2025
Signed-off-by: Florian Amsallem <[email protected]>
Signed-off-by: Florian Amsallem  <[email protected]>
Signed-off-by: Florian Amsallem <[email protected]>
@flomonster flomonster merged commit f838cd2 into main Feb 27, 2025
1 check passed
@flomonster flomonster deleted the osrd-stage2 branch February 27, 2025 14:00
@cornelius
Copy link
Member

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants