Chore/merge-v4-dev-@261418 #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
julien-deramond
commented
May 31, 2022
•
julien-deramond
commented
- twbs/bootstrap@5299abe: Already done in Boosted
- twbs/bootstrap@3b63d50: Already done in Boosted
- twbs/bootstrap@bae047f
- twbs/bootstrap@0090af6
- twbs/bootstrap@7613953
- twbs/bootstrap@d36b1a4
- twbs/bootstrap@d9481ee
- twbs/bootstrap@6a50084
- twbs/bootstrap@e4dc2e9
- twbs/bootstrap@7d57d9a
- twbs/bootstrap@c1b42e3: Already done in Boosted
- twbs/bootstrap@c043a75
- twbs/bootstrap@261b418
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
julien-deramond
commented
May 31, 2022
| <a class="nav-link" id="v-pills-messages-tab" data-toggle="pill" href="#v-pills-messages" role="tab" aria-controls="v-pills-messages" aria-selected="false">Messages</a> | ||
| <a class="nav-link" id="v-pills-settings-tab" data-toggle="pill" href="#v-pills-settings" role="tab" aria-controls="v-pills-settings" aria-selected="false">Settings</a> | ||
| <button class="nav-link active" id="v-pills-home-tab" data-toggle="pill" data-target="#v-pills-home" type="button" role="tab" aria-controls="v-pills-home" aria-selected="true">Home</button> | ||
| <button class="nav-link" id="v-pills-profile-tab" data-toggle="pill" data-target="#v-pills-profile" type="button" role="tab" aria-controls="v-pills-profile" aria-selected="false">Profile</buttona> |
There was a problem hiding this comment.
julien-deramond
force-pushed
the
chore/merge-v4-dev@261b418
branch
from
2952750 to
e350cae
Compare
| @@ -350,13 +350,13 @@ Note that the tab JavaScript plugin **does not** support tabbed interfaces that | |||
| <div class="bd-example bd-example-tabs"> | |||
| <ul class="nav nav-tabs" id="myTab" role="tablist"> | |||
| <li class="nav-item" role="presentation"> | |||
| <a class="nav-link active" id="home-tab" data-toggle="tab" href="#home" role="tab" aria-controls="home" aria-selected="true">Home</a> | |||
| <button class="nav-link active" id="home-tab" data-toggle="tab" data-target="#home" type="button" role="tab" aria-controls="home" aria-selected="true">Home</button> | |||
There was a problem hiding this comment.
FYI, we lost the dynamic focus using <button> instead of <a> + We have a different behavior than Bs
louismaximepiton
approved these changes
Jun 2, 2022
|
I let you tackle the things directly in Boostrap and create an issue for the problems not coming from this PR. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.