Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install MSRV toolchain as default #199

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Install MSRV toolchain as default #199

merged 2 commits into from
Jul 13, 2021

Conversation

adamreichold
Copy link
Member

@adamreichold adamreichold commented Jul 12, 2021 •
edited
Loading

To ensure that it is used instead of the one shipped with the base image.

Fixes #198

@adamreichold adamreichold changed the title Install MSRV toolchain as local override Install MSRV toolchain as default Jul 12, 2021
@adamreichold
Copy link
Member Author

Using just a local override does not work due to the creation of a standalone example project in a separate folder.

@adamreichold adamreichold mentioned this pull request Jul 12, 2021
Closed
@adamreichold adamreichold marked this pull request as ready for review July 12, 2021 14:59
kngwyu
kngwyu approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kngwyu kngwyu merged commit b9b18aa into PyO3:main Jul 13, 2021
@adamreichold adamreichold deleted the msrv-override branch July 13, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust 1.41 compiler error with rust-numpy 0.14.0
2 participants
@adamreichold @kngwyu