Drop as_cell_slice and add raw array views instead
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
commented
Jan 17, 2022
| pyo3::Python::with_gil(|py| { | ||
| let not_contiguous = not_contiguous_array(py); | ||
| let raw_array_view = not_contiguous.as_raw_array(); | ||
| assert_eq!(unsafe { raw_array_view.deref_into_view()[0] }, 1); |
There was a problem hiding this comment.
One downside appears to be that ndarray does not provide indexing into raw views, only dereferencing the whole view.
There was a problem hiding this comment.
Yeah it's not very userfriendly, but I think this is rather a downside of raw view, not that of having conversion API
There was a problem hiding this comment.
Opened rust-ndarray/ndarray#1151 to expand the ndarray interface.
adamreichold
force-pushed
the
drop-cell-slice
branch
from
d234b53 to
46af291
Compare
…e absence of aliasing views cannot be guaranteed.
adamreichold
force-pushed
the
drop-cell-slice
branch
from
46af291 to
eb37647
Compare
kngwyu
approved these changes
Jan 22, 2022
| pyo3::Python::with_gil(|py| { | ||
| let not_contiguous = not_contiguous_array(py); | ||
| let raw_array_view = not_contiguous.as_raw_array(); | ||
| assert_eq!(unsafe { raw_array_view.deref_into_view()[0] }, 1); |
There was a problem hiding this comment.
Yeah it's not very userfriendly, but I think this is rather a downside of raw view, not that of having conversion API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first and already discussed fix towards a resolution of #258