-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend our type signatures of inner and dot to match NumPy's types. #285
Conversation
aec633a
to
7ecc147
Compare
7ecc147
to
3478085
Compare
3478085
to
00b035d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I didn't notice that this can cause an error, thanks.
Could you please some test cases that extract floats/integers also in (non-doc) tests?
Also, can we do the same for einsum?
Yeah, I think the effective signature of the capsule API is quite unfortunate considering a zero-dimensional array can be used almost exactly like a scalar in Python code.
Added more tests for
Indeed this implies here too depending on the summation performed. Added as a separate commit. |
As this break the API anyway, I took the liberty of renaming the |
8cf5e84
to
1ec9e4f
Compare
Slipped in a further change to make use of |
1ec9e4f
to
1e0fbef
Compare
@kngwyu Are you satisfied with the adjustments? |
af505de
to
9bcce43
Compare
9bcce43
to
5bc031d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late. Thank you for addressing my requests!
Closes #284