Fixes and refinements to dynamic borrow checking #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thing here is making
PyArray::resize
unsafe as it may reallocate the array in-place thereby invalidate all existing pointers into its interior. The safe replacement isPyReadwriteArray::resize
which will release and re-acquire an exclusive borrow of the array.Does anybody now of other "destructive" methods which would need the same treatment?
I think was arguably unsound for the previous
PyReadonlyArray
as well as the following appears to work: