Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code inconsistent in function Clean_Func_Calls #10

Closed
pse1202 opened this issue Aug 22, 2019 · 4 comments
Closed

Code inconsistent in function Clean_Func_Calls #10

pse1202 opened this issue Aug 22, 2019 · 4 comments

Comments

@pse1202
Copy link

pse1202 commented Aug 22, 2019

PSDecode/PSDecode.psm1

Line 271 in 2c6badf

Write-Verbose "[Clean_Func_Calls] Replacing: $($match)`tWith: $($match.ToString().replace('(','').replace(')',''))"

PSDecode/PSDecode.psm1

Line 272 in 2c6badf

$Command = $Command.Replace($match, $match.ToString().replace('"','').replace("'",''))

In the function Clean_Func_Calls, the verbose logging suggests removing the parentheses and the actual command removes the quotes.

However, I think the code is supposed to remove the backticks from the function names judging by the name "Clean_Func_Calls".

Can this be checked? Thanks

BTW, thanks for this useful tool.
R3MRUM added a commit that referenced this issue Aug 25, 2019
@R3MRUM
Fixed Verbose logging message
e92c783 
Verbose logging message referenced actions for another function. Updated message to reflect actual action being performed. Reported as Issue #10
@R3MRUM
Copy link
Owner

R3MRUM commented Aug 25, 2019

Good catch! I just pushed an updated version with messaging that reflects the actual action being performed.

@R3MRUM R3MRUM closed this as completed Aug 25, 2019
@R3MRUM
Copy link
Owner

R3MRUM commented Aug 25, 2019 •
edited
Loading

accidentally introduced a new syntax error. fixing now

@R3MRUM R3MRUM reopened this Aug 25, 2019
@R3MRUM
Copy link
Owner

R3MRUM commented Aug 25, 2019

Should be fixed now. If you can, please verify on your end so I can close this out

@pse1202
Copy link
Author

pse1202 commented Aug 26, 2019

LGTM

@pse1202 pse1202 closed this as completed Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pse1202 @R3MRUM