Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique selector for Ramen's dr-cluster-operator and hub-operator deployments #277

Closed
vdeenadh opened this issue Sep 16, 2021 · 0 comments · Fixed by #286
Closed

Use unique selector for Ramen's dr-cluster-operator and hub-operator deployments #277

vdeenadh opened this issue Sep 16, 2021 · 0 comments · Fixed by #286
Assignees
@hatfieldbrian
Labels
bug Something isn't working

Comments

@vdeenadh
Copy link
Member

vdeenadh commented Sep 16, 2021 •
edited
Loading

ramen-dr-cluster-operator and ramen-hub-operator uses the same label control-plane: controller-manager. Instead, use unique labels, like app:dr-cluster-operator and app:hub-operator.

While at it, change the container name from a generic manager to more unique dr-cluster-operator and hub-operator.
@vdeenadh vdeenadh changed the title Use unique selector for ramen-dr-cluster-operator and ramen-hub-operator Use unique selector for ramen's dr-cluster-operator and hub-operator deployments Sep 20, 2021
@vdeenadh vdeenadh changed the title Use unique selector for ramen's dr-cluster-operator and hub-operator deployments Use unique selector for Ramen's dr-cluster-operator and hub-operator deployments Sep 20, 2021
@ShyamsundarR ShyamsundarR added bug Something isn't working priority-1 labels Sep 20, 2021
@vdeenadh vdeenadh assigned vdeenadh and hatfieldbrian and unassigned vdeenadh Sep 20, 2021
hatfieldbrian added a commit to hatfieldbrian/ramen that referenced this issue Sep 22, 2021
@hatfieldbrian
add Deployment match and template and Service selector labels contain…
5f366d4 
…ing operator name RamenDR#277

	- install kustomize version 3.8.8 including inline transformer support for hub and dr-cluster deployments
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225

Signed-off-by: hatfieldbrian <[email protected]>
@hatfieldbrian hatfieldbrian mentioned this issue Sep 22, 2021
Merged
hatfieldbrian added a commit to hatfieldbrian/ramen that referenced this issue Sep 23, 2021
@hatfieldbrian
label Deployment, ReplicaSet, Pod, and Service with operator name Ram…
8224f2d 
…enDR#277

	- increase kustomize version from 3.8.7 to 3.8.8 for inline transformer support
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225
		- user must remove existing bin/kustomize if its version is less than 3.8.8

Signed-off-by: hatfieldbrian <[email protected]>
ShyamsundarR pushed a commit that referenced this issue Sep 23, 2021
@hatfieldbrian @ShyamsundarR
label Deployment, ReplicaSet, Pod, and Service with operator name #277
67dfd1e 
	- increase kustomize version from 3.8.7 to 3.8.8 for inline transformer support
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225
		- user must remove existing bin/kustomize if its version is less than 3.8.8

Signed-off-by: hatfieldbrian <[email protected]>
ShyamsundarR referenced this issue in red-hat-storage/ramen Sep 23, 2021
@hatfieldbrian @ShyamsundarR
label Deployment, ReplicaSet, Pod, and Service with operator name #277
99b0d68 
	- increase kustomize version from 3.8.7 to 3.8.8 for inline transformer support
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225
		- user must remove existing bin/kustomize if its version is less than 3.8.8

Signed-off-by: hatfieldbrian <[email protected]>
raghavendra-talur pushed a commit to raghavendra-talur/ramen that referenced this issue Jul 30, 2024
@ShyamsundarR
Merge pull request RamenDR#277 from red-hat-storage/sync_ds--main
e0a2bfa 
Syncing latest changes from main for ramen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hatfieldbrian hatfieldbrian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@ShyamsundarR @vdeenadh @hatfieldbrian