Skip to content

Commit 6f7a17b

Browse files
JumasJumas
authored
feat: JS modules alternatives for currently existing JS entities (#245)
1 parent d5e653d commit 6f7a17b

11 files changed

+1225
-7
lines changed

‎.gitignore

+4
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ replay_pid*
3535
target/
3636
*.iml
3737
dependency-reduced-pom.xml
38+
39+
app/node/
40+
app/node_modules/
41+
app/package-lock.json

‎app/package.json

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"dependencies": {
3+
},
4+
"devDependencies": {
5+
"jsdom": "^24.0.0",
6+
"sinon": "^19.0.2",
7+
"chai": "^4.3.4",
8+
"mocha": "10.1.0"
9+
},
10+
"name": "maven-js-project",
11+
"scripts": {
12+
"test": "mocha src/test/js/**/*.js"
13+
},
14+
"type": "module",
15+
"version": "1.0.0"
16+
}

‎app/pom.xml

+46
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@
1111
<name>Versatile extension for developing additional extensions within Polarion ALM: common code and resources</name>
1212
<artifactId>ch.sbb.polarion.extension.generic.app</artifactId>
1313

14+
<properties>
15+
<frontend-maven-plugin.version>1.15.0</frontend-maven-plugin.version>
16+
<frontend-maven-plugin.nodeVersion>v20.17.0</frontend-maven-plugin.nodeVersion>
17+
<frontend-maven-plugin.npmVersion>10.8.3</frontend-maven-plugin.npmVersion>
18+
</properties>
19+
1420
<profiles>
1521
<profile>
1622
<id>gpg-sign</id>
@@ -70,6 +76,46 @@
7076
<groupId>org.apache.maven.plugins</groupId>
7177
<artifactId>maven-source-plugin</artifactId>
7278
</plugin>
79+
80+
<plugin>
81+
<groupId>com.github.eirslett</groupId>
82+
<artifactId>frontend-maven-plugin</artifactId>
83+
<version>${frontend-maven-plugin.version}</version>
84+
<executions>
85+
<execution>
86+
<id>install-node-and-npm</id>
87+
<goals>
88+
<goal>install-node-and-npm</goal>
89+
</goals>
90+
<configuration>
91+
<nodeVersion>${frontend-maven-plugin.nodeVersion}</nodeVersion>
92+
<npmVersion>${frontend-maven-plugin.npmVersion}</npmVersion>
93+
</configuration>
94+
</execution>
95+
96+
<!-- Install JavaScript dependencies using npm -->
97+
<execution>
98+
<id>npm-install</id>
99+
<goals>
100+
<goal>npm</goal>
101+
</goals>
102+
<configuration>
103+
<arguments>install</arguments>
104+
</configuration>
105+
</execution>
106+
107+
<!-- Run JavaScript tests -->
108+
<execution>
109+
<id>npm-test</id>
110+
<goals>
111+
<goal>npm</goal>
112+
</goals>
113+
<configuration>
114+
<arguments>run test</arguments>
115+
</configuration>
116+
</execution>
117+
</executions>
118+
</plugin>
73119
</plugins>
74120
</build>
75121
</project>

‎app/src/main/resources/META-INF/resources/common/jsp/configurations.jsp

+6-6
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
<label id="configurations-label"><span class="configuration-label-capitalized">Configuration</span>:</label>
88
<div id="configurations-select"></div>
99
<div class="action-buttons">
10-
<button class="toolbar-button" onclick="Configurations.editConfiguration()">
10+
<button id="configurations-button-edit" class="toolbar-button" onclick="Configurations.editConfiguration()">
1111
<img class="button-image" src="/polarion/ria/images/actions/edit.gif?bundle=<%= bundleTimestamp %>">Rename
1212
</button>
13-
<button class="toolbar-button" onclick="Configurations.deleteConfiguration()">
13+
<button id="configurations-button-delete" class="toolbar-button" onclick="Configurations.deleteConfiguration()">
1414
<img class="button-image" src="/polarion/ria/images/actions/delete.gif?bundle=<%= bundleTimestamp %>">Delete
1515
</button>
16-
<button class="new-configuration toolbar-button" style="display: inline-block" onclick="Configurations.newConfiguration()">
16+
<button id="configurations-button-create" class="new-configuration toolbar-button" style="display: inline-block" onclick="Configurations.newConfiguration()">
1717
<img class="button-image" src="/polarion/ria/images/control/tablePlus.png?bundle=<%= bundleTimestamp %>">Add new
1818
</button>
1919
</div>
@@ -29,13 +29,13 @@
2929
<label for="edit-configuration-input" class="edit-configuration">Edit <span class="configuration-label-capitalized">Configuration</span>:</label>
3030
<input type="text" id="edit-configuration-input" class="edit-configuration" maxlength="40" />
3131
<div class="action-buttons">
32-
<button class="toolbar-button" onclick="Configurations.cancelEditConfiguration()">
32+
<button id="configurations-button-cancel-edit" class="toolbar-button" onclick="Configurations.cancelEditConfiguration()">
3333
<img class="button-image" src="/polarion/ria/images/actions/cancel.gif?bundle=<%= bundleTimestamp %>">Cancel
3434
</button>
35-
<button class="new-configuration toolbar-button" onclick="Configurations.saveConfiguration()">
35+
<button id="configurations-button-save" class="new-configuration toolbar-button" onclick="Configurations.saveConfiguration()">
3636
<img class="button-image" src="/polarion/ria/images/actions/save.gif?bundle=<%= bundleTimestamp %>">Save
3737
</button>
38-
<button class="edit-configuration toolbar-button" onclick="Configurations.updateConfiguration()">
38+
<button id="configurations-button-update" class="edit-configuration toolbar-button" onclick="Configurations.updateConfiguration()">
3939
<img class="button-image" src="/polarion/ria/images/actions/save.gif?bundle=<%= bundleTimestamp %>">Update
4040
</button>
4141
</div>

‎app/src/main/resources/js/configurations.js

-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ const Configurations = {
253253
});
254254
}
255255
document.querySelectorAll('.html-input textarea').forEach(textarea => {
256-
textarea.placeholder = enabled ? "Enter configuration content here" : "";
257256
textarea.disabled = !enabled;
258257
});
259258
document.querySelectorAll('.content-area select').forEach(select => {

0 commit comments

Comments
 (0)