Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Js modules refactoring #245

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Js modules refactoring #245

merged 3 commits into from
Mar 4, 2025

Conversation

Jumas
Copy link
Contributor

@Jumas Jumas commented Mar 4, 2025 •
edited
Loading

Proposed changes

Introduce modules alternatives for currently existing entities (SbbCommon, Configurations etc.)

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@Jumas Jumas requested review from a team as code owners March 4, 2025 09:30
@Jumas Jumas marked this pull request as draft March 4, 2025 09:31
@Jumas Jumas linked an issue Mar 4, 2025 that may be closed by this pull request
Introduce JS modules alternatives for existing JS entities #244
Closed
@Jumas Jumas marked this pull request as ready for review March 4, 2025 12:50
@Jumas Jumas enabled auto-merge (squash) March 4, 2025 12:51
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Jumas Jumas merged commit 6f7a17b into main Mar 4, 2025
19 checks passed
@Jumas Jumas deleted the js_modules_refactoring branch March 4, 2025 14:46
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurtsevich-sbb yurtsevich-sbb yurtsevich-sbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce JS modules alternatives for existing JS entities
2 participants
@Jumas @yurtsevich-sbb