fix: 350 bug delete node or trainrunsections cause low performance (#351

) * fix: performance issue fixed * fix: performance issue fixed
SchweizerischeBundesbahnen · Nov 14, 2024 · 72f8599 · 72f8599
1 parent 721876e
commit 72f8599
Showing 1 changed file with 24 additions and 9 deletions.
diff --git a/src/app/services/data/trainrunsection.service.ts b/src/app/services/data/trainrunsection.service.ts
@@ -814,31 +814,46 @@ export class TrainrunSectionService implements OnDestroy {
     this.operation.emit(new TrainrunOperation(OperationType.update, trainrunSection.getTrainrun()));
   }
 
-  deleteListOfTrainrunSections(trainrunSections: TrainrunSection[]) {
+  deleteListOfTrainrunSections(trainrunSections: TrainrunSection[], enforceUpdate = true) {
     trainrunSections.forEach((trainrunSection) => {
-      this.deleteTrainrunSectionAndCleanupNodes(trainrunSection);
+      this.deleteTrainrunSectionAndCleanupNodes(trainrunSection, false);
     });
-    this.trainrunSectionsUpdated();
+    if (enforceUpdate) {
+      this.nodeService.transitionsUpdated();
+      this.nodeService.connectionsUpdated();
+      this.trainrunService.trainrunsUpdated();
+      this.trainrunSectionsUpdated();
+    }
   }
 
-  deleteAllVisibleTrainrunSections() {
+  deleteAllVisibleTrainrunSections(enforceUpdate = true) {
     const allTrainrunSections = this.trainrunSectionsStore.trainrunSections;
     allTrainrunSections.forEach((trainrunSection: TrainrunSection) => {
       if (this.filterService.filterTrainrunsection(trainrunSection)) {
-        this.deleteTrainrunSectionAndCleanupNodes(trainrunSection);
+        this.deleteTrainrunSectionAndCleanupNodes(trainrunSection, false);
       }
     });
-    this.trainrunSectionsUpdated();
+    if (enforceUpdate){
+      this.nodeService.transitionsUpdated();
+      this.nodeService.connectionsUpdated();
+      this.trainrunService.trainrunsUpdated();
+      this.trainrunSectionsUpdated();
+    }
   }
 
-  deleteAllNonVisibleTrainrunSections() {
+  deleteAllNonVisibleTrainrunSections(enforceUpdate = true) {
     const allTrainrunSections = this.trainrunSectionsStore.trainrunSections;
     allTrainrunSections.forEach((trainrunSection: TrainrunSection) => {
       if (!this.filterService.filterTrainrunsection(trainrunSection)) {
-        this.deleteTrainrunSectionAndCleanupNodes(trainrunSection);
+        this.deleteTrainrunSectionAndCleanupNodes(trainrunSection, false);
       }
     });
-    this.trainrunSectionsUpdated();
+    if (enforceUpdate) {
+      this.nodeService.transitionsUpdated();
+      this.nodeService.connectionsUpdated();
+      this.trainrunService.trainrunsUpdated();
+      this.trainrunSectionsUpdated();
+    }
   }
 
   deleteTrainrunSection(trainrunSectionId: number, enforceUpdate = true) {