fix: 350 bug delete node or trainrunsections cause low performance #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
aiAdrian
changed the title
louisgreiner
approved these changes
Nov 14, 2024
aiAdrian
deleted the
350-bug-delete-node-or-trainrunsections-cause-low-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting multiple nodes or trainrun sections, it's crucial that the delete loop doesn't refresh the rendering for each deleted element. The deletions should be performed all at once at the end - only one update (refresh) should be triggered. This is now implemented and improves the performance.
#350
Issues
Checklist
documentation/