194 feature request shareing through email identifier instead of subject identifier sub #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
documentation
…nstead-of-subject-identifier-sub' of https://github.com/SchweizerischeBundesbahnen/netzgrafik-editor-frontend into 194-feature-request-shareing-through-email-identifier-instead-of-subject-identifier-sub
chenkins
suggested changes
Jul 24, 2024
There was a problem hiding this comment.
Main design comments in backend pr review , only two minor change requests here.
src/app/view/project/project-dialog/project-form/project-form.component.ts
Outdated
Show resolved
Hide resolved
| @@ -49,11 +49,11 @@ const userIdsValidator = (control: UntypedFormControl) => { | |||
| return null; | |||
| } | |||
| const userIds: string[] = control.value; | |||
| const invalidIds = userIds.filter((id) => !id.match(/^(u|ue|e)\d+$/)); | |||
| const invalidIds = userIds.filter((id) => | |||
There was a problem hiding this comment.
@aiAdrian rename variable to invalidEmails. Also rename userIdsValidator
…netzgrafik-editor-frontend into 194-feature-request-shareing-through-email-identifier-instead-of-subject-identifier-sub
chenkins
approved these changes
Jul 25, 2024
chenkins
approved these changes
Jul 25, 2024
aiAdrian
requested review from
chenkins and
louisgreiner
and removed request for
chenkins
louisgreiner
approved these changes
Jul 29, 2024
emersion
reviewed
Jul 31, 2024
| // email adresse validator: regex to match emails using the expression | ||
| const invalidEmailPattern = userIds.filter((id) => { | ||
| const retVal = | ||
| id.match(/^([a-z0-9_\\.-]+)@([\da-z\\.-]+)\.([a-z\\.]{2,6})|(u|ue|e)\d+$/); |
There was a problem hiding this comment.
Same as https://github.com/SchweizerischeBundesbahnen/netzgrafik-editor-backend/pull/16/files#r1698074806: this is too restrictive.
emersion
reviewed
Jul 31, 2024
...ariant/variant-view/variant-history/version-entry-layout/version-entry-layout.component.scss
Outdated
Show resolved
Hide resolved
aiAdrian
deleted the
194-feature-request-shareing-through-email-identifier-instead-of-subject-identifier-sub
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request requires as well the backend pull request SchweizerischeBundesbahnen/netzgrafik-editor-backend#16
User can now enter partner's email adresse to share projects.
Examples