Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local dev environment. #196

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix local dev environment. #196

merged 1 commit into from
Jul 24, 2024

Conversation

chenkins
Copy link
Contributor

Description

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@chenkins chenkins requested a review from aiAdrian as a code owner July 24, 2024 12:41
@aiAdrian
Copy link
Collaborator

Thank you !

@aiAdrian aiAdrian merged commit a7bdd6c into SchweizerischeBundesbahnen:main Jul 24, 2024
6 checks passed
@emersion
Copy link
Collaborator

Note that this PR breaks the docker setup: the Angular build now no longer creates language directories (en/, de/, etc) but the nginx configuration file still assumes these exist.

This issue will be fixed once #173 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiAdrian aiAdrian aiAdrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenkins @aiAdrian @emersion