Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to one-stop-shop Docker Compose based demo. #403

Conversation

chenkins
Copy link
Contributor

@chenkins chenkins commented Feb 7, 2025

Description

Add link to one-stop-shop Docker Compose based demo.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@chenkins chenkins requested a review from aiAdrian as a code owner February 7, 2025 14:30
@louisgreiner
Copy link
Collaborator

Tested, it works great, and indeed in a single command line 🥳

We already publish a build of NGE after every PR, see associated GitHub worflow, available on NPM. However, we only publish a build of the standalone (= front-end-compatible only) version of NGE.

Would it be interesting to publish a NPM package of the NGE complete version on each release, allowing you to get up to date NGE version for this environment ?

@louisgreiner louisgreiner self-requested a review February 10, 2025 10:31
@louisgreiner
Copy link
Collaborator

Do you consider, one day, to merge the frontend and backend repositories ?

This project from Flatland could be used for that, then they won't need to maintain their project

@chenkins
Copy link
Contributor Author

chenkins commented Feb 10, 2025

@louisgreiner

Tested, it works great, and indeed in a single command line 🥳
🥳

We already publish a build of NGE after every PR, see associated GitHub worflow, available on NPM. However, we only publish a build of the standalone (= front-end-compatible only) version of NGE.

Would it be interesting to publish a NPM package of the NGE complete version on each release, allowing you to get up to date NGE version for this environment ?

Docker Image is built on every push to main as well. I think for demo purposes, it's good netzgrafik-editor-docker-compose does not rely on local builds (which can fail... and which can take long...) but just uses the full-built Docker images as used in the deployments of https://nge.flatland.cloud.

Do you consider, one day, to merge the frontend and backend repositories ?

Merging frontend and backend repositories:
➕ no dependency management in deployment (frontend version -> backend version)
➕ all-in-one demo and documentation can be placed in same repo
➖ some work for no big pain (?)
➖ backend is rebuilt on every release (although it hasn't changed at all for long)

@aiAdrian
Copy link
Collaborator

aiAdrian commented Feb 13, 2025

@louisgreiner
Please check and complete

#405

When ok -> merge and close this PR thanks

@louisgreiner
Copy link
Collaborator

Perfect for me, I let @chenkins close this nice PR :-)

@chenkins
Copy link
Contributor Author

Perfect for me, I let @chenkins close this nice PR :-)

@louisgreiner Don't have the permissions to merge in this repo 😉

@louisgreiner louisgreiner merged commit 95a8445 into SchweizerischeBundesbahnen:main Feb 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants