Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent closing a view if it displays a message box with view modality #344

Closed
mofogasy opened this issue Aug 12, 2022 · 1 comment
Closed

Prevent closing a view if it displays a message box with view modality #344

mofogasy opened this issue Aug 12, 2022 · 1 comment
Labels
bug comp: workbench

Comments

@mofogasy
Copy link
Contributor

Describe the bug

When a message box with view modality is open in a view, it should not be possible to close the view.
Right now, the view cannot be closed through the keystroke Ctrl+k or the close button (x) of the tab (since it is hidden), which is the correct behavior.
However, the view can still be closed through the context menu of its tab (Close tab and Close all tabs), which is wrong.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Testing App
  2. Click on 'Workbench Messagebox'
  3. Click on 'Open message box' button
  4. Right-click on the tab
  5. The context menu entries Close tab and Close all tabs are active and can be used to close the tab.

Expected behavior

The context menu entries Close tab and Close all tabs should be inactive.

Environment

Please complete the following information:

  • SCION Workbench version: [13.0.0-beta.2]
  • SCION Workbench Client version: [1.0.0-beta.10]
  • Angular version: [13.3.4]
  • Browser: [Chrome 104]
  • OS: [Windows 10]
  • Device: [Desktop]
@mofogasy mofogasy changed the title Prevent closing a tab if its contained view displays a message box with view modality Prevent closing a view if it displays a message box with view modality Aug 12, 2022
@danielwiehl
Copy link
Collaborator

If fixed we can enable the test message-box.e2e-spec.ts: should prevent closing a view if it displays a message box with view modality

danielwiehl added a commit that referenced this issue May 2, 2024
@danielwiehl
fix(workbench/view): fix issues related to preventing views from closing
0327bae 
To fix issues related to preventing views from closing, the guard is no longer implemented as an Angular "CanDeactivate" guard but runs before the Angular navigation.

This commit fixes the following issues:
- guard now also runs on child routes
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed.
- the guard can perform an Angular navigation, e.g., display a message box with route content.

closes #27, closes #344

BREAKING CHANGE: Interface and method for intercepting (or preventing) closing of a view has changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippets illustrate how a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
86a23d0 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
58fabaa 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
db5916c 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
021f5be 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
8a8f41b 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
6169afe 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
1217a8f 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
25e2763 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
26d005b 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
e8d32f6 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 3, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
b422381 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 4, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
82c3f93 
The guard now runs before the Angular navigation. Previously, it was implemented as an Angular `CanDeactivate` guard.

The following issues have been fixed:
- guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
e984d1c 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
031c621 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
eafd056 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
``ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
bb50200 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
290d144 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
c0c3b15 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
874cc97 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
535816d 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues preventing views from closing
0d45787 
The following issues have been fixed:
- `CanClose` guard now also runs on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

The following snippet illustrates what a migration could look like:

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues to prevent a view from closing
ac68c70 
The following issues have been fixed:
- `CanClose` guard now also works on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 6, 2024
@danielwiehl
fix(workbench/view): fix issues to prevent a view from closing
b5dc33c 
The following issues have been fixed:
- `CanClose` guard now also works on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
danielwiehl added a commit that referenced this issue May 7, 2024
@danielwiehl
fix(workbench/view): fix issues to prevent a view from closing
e23dbb7 
The following issues have been fixed:
- `CanClose` guard now also works on child routes;
- multiple views can be closed simultaneously, even if some views prevent closing; previously, Angular navigation was canceled, causing no views to be closed;
- `CanClose` guard can now perform an Angular navigation, e.g., to display a dialog with routed content;

closes #27, closes #344

BREAKING CHANGE: Interface and method for preventing closing of a view have changed.

To migrate, implement the `CanClose` instead of the `WorkbenchViewPreDestroy` interface.

**Before migration:**
```ts
class YourComponent implements WorkbenchViewPreDestroy {
  public async onWorkbenchViewPreDestroy(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```

**After migration:**

```ts
class YourComponent implements CanClose {
  public async canClose(): Promise<boolean> {
    // return `true` to close the view, otherwise `false`.
  }
}
```
@danielwiehl danielwiehl mentioned this issue May 7, 2024
Merged
17 tasks
@github-project-automation github-project-automation bot moved this to Done in SCION Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug comp: workbench
Projects
SCION
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielwiehl @mofogasy