-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload All and Project Path #4903
Conversation
src/slic3r/GUI/Plater.cpp
Outdated
} | ||
if (!found) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a bit the changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the file not found in the current directory and exists on the initial file path it will be reloaded from there. Otherwise user will be prompted to select file manually.
So the file in the current directory has priority on the sorce file. This allows to copy project file to other directory, press Reload All and have same project with new STL files loaded.
But if you didn't move the project file to other place where new STL files exist Reload All will work the same way as before these changes were made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the file not found in the current directory and exists on the initial file path it will be reloaded from there. Otherwise user will be prompted to select file manually.
This logic change sounds not very right to me.
The initial file path should have the priority IMO. It's also the logic in PS, can we revert the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It's better to have Reload All with another logic in the main branch than not to have at all)
I will continue using this logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It's better to have Reload All with another logic in the main branch than not to have at all)
I will continue using this logic.
I'm not sure if I understand it.
Can you clarify?
This logic works the same way as original one untill you copy amf project to another directory where new stl files with the same names exist. It's very convenient for me as a 3D designer when I have several versions of a model. Different sizes for instance. You simply copy project to another folder, Reload All and you have new version ready to print. |
I see. I understand this is convenient for this special case. |
The users wil not certainly even notice the difference but you are owner and you decide. |
I agree that in most cases, it won't cause any difference. |
I agree. Do you want me to change the pool request or can you do it yourself? |
Please go ahead and change the PR. Appreciate it. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you!
Description
Screenshots