Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create_task_log.py #3

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Update create_task_log.py #3

merged 1 commit into from
Sep 4, 2019

Conversation

sebastientinel
Copy link
Contributor

@sebastientinel sebastientinel commented Jul 9, 2019 •
edited
Loading

Use of CaseTaskLog objects as defined in models.

@sebastientinel
Update create_task_log.py
a3e8e38 
Use of CreateTaskLogAction object as defined in models.
jinpingh
jinpingh approved these changes Jul 9, 2019
View reviewed changes
Copy link

@jinpingh jinpingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arm4b
arm4b suggested changes Aug 1, 2019
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please include changelog record in CHANGES.md indicating exactly the scope of the change. We'll need also pack version update in pack.yaml to get this merged.

@agix agix merged commit 7ab2efe into StackStorm-Exchange:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b requested changes

@jinpingh jinpingh jinpingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastientinel @arm4b @jinpingh @agix