Fix text decorations #1448
Merged
Fix text decorations #1448
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub6Resources
force-pushed
the
fix_text-decorations
branch
from
b078459 to
ac33d1a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
=======================================
Coverage 64.04% 64.05%
=======================================
Files 39 39
Lines 3026 3035 +9
=======================================
+ Hits 1938 1944 +6
- Misses 1088 1091 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We need to explicitly set the underline color to the same blue as we set the text. fixes: Sub6Resources#1414 We need to explicitly set the text decoration color.
Cascade text decoration attributes color, thickness and style in addition to the textdecoration itself. fixes: Sub6Resources#1361
When you use a "u" html tag, you expect the underline to match the textcolor. Therefore we need to get the style of the child element and use it's color if it exists.
If you have a link with a color style, the expectation is that the underline of the link is the same color, hence we need to implicitly set the text decoration color as well, when we apply the text color.
Sub6Resources
force-pushed
the
fix_text-decorations
branch
from
ac33d1a to
09418a6
Compare
Sub6Resources
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of text decoration related regressions.