#66 fix typos and bugs

analyzers/File_Info/fileinfo_analyzer.py

@@ -162,7 +162,7 @@ def summary(self, fullReport):
                 level = 'suspicious'
             taxonomies.append(self.build_taxonomy(level, namespace, predicate, value))
         else:
-            value = fullReport['filetype']
+            value = "\"{}\"".format(fullReport['filetype'])
             level = 'info'
             taxonomies.append(self.build_taxonomy(level, namespace, predicate, value))
 

analyzers/FireHOLBlocklists/firehol_blocklists.py

@@ -27,7 +27,7 @@ def __init__(self):
 
         # Check if directory exists
         if not os.path.exists(self.path):
-            os.mkdir(self.path, mode=0o700)
+            os.mkdir(self.path, 0700)
             # Downloading/updating the list is implemented with an external cronjob which git pulls the repo
 
         # Read files in the given path and prepare file lists for ip- and netsets

analyzers/JoeSandbox/JoeSandbox_File_Analysis_Inet.json

@@ -1,6 +1,6 @@
 {
     "name": "JoeSandbox_File_Analysis_Inet",
-    "version": "1.1",
+    "version": "2.0",
     "author": "CERT-BDF",
     "url": "https://github.com/CERT-BDF/Cortex-Analyzers",
     "license": "AGPL-V3",

analyzers/JoeSandbox/JoeSandbox_File_Analysis_Noinet.json

@@ -1,6 +1,6 @@
 {
     "name": "JoeSandbox_File_Analysis_Noinet",
-    "version": "1.1",
+    "version": "2.0",
     "author": "CERT-BDF",
     "url": "https://github.com/CERT-BDF/Cortex-Analyzers",
     "license": "AGPL-V3",

analyzers/JoeSandbox/JoeSandbox_Url_Analysis.json

@@ -1,6 +1,6 @@
 {
     "name": "JoeSandbox_Url_Analysis",
-    "version": "1.1",
+    "version": "2.0",
     "author": "CERT-BDF",
     "url": "https://github.com/CERT-BDF/Cortex-Analyzers",
     "license": "AGPL-V3",

analyzers/JoeSandbox/joesandbox_analyzer.py

@@ -35,15 +35,15 @@ def summary(self, raw):
 
         r = raw['detection']
 
-        taxonomy["value"] = "\"{}/{}\"".format(r["score"], r["maxscore"])
+        value = "\"{}/{}\"".format(r["score"], r["maxscore"])
+
         if r["clean"]:
             level = "safe"
         elif r["suspicious"]:
             level = "suspicious"
-            value = "Suspicious"
         elif r["malicious"]:
             level = "malicious"
-            value = "Malicious"
+
 
 
         else:

analyzers/MISP/misp.py

@@ -28,7 +28,7 @@ def summary(self, raw):
 
         # return number of unique events
         if data == []:
-            value = "\"0\""
+            value = "\"0\event\""
             taxonomies.append(self.build_taxonomy(level, namespace, predicate, value))
         else:
             value = "\"{} event(s)\"".format(len(list(set(data))))

analyzers/Yara/yara_analyzer.py

@@ -17,8 +17,6 @@ def __init__(self):
         if isinstance(self.rulepaths, str):
             self.rulepaths = [self.rulepaths]
 
-        print(self.rulepaths)
-
         self.ruleset = []
         for rulepath in self.rulepaths:
             if os.path.isfile(rulepath):
@@ -55,14 +53,14 @@ def summary(self, raw):
         namespace = "Yara"
         predicate = "Match"
 
-        value = "\"{} rules\"".format(len(raw["results"]))
+        value = "\"{} rule(s)\"".format(len(raw["results"]))
         if len(raw["results"]) == 0:
             level = "safe"
         else:
             level = "malicious"
 
         taxonomies.append(self.build_taxonomy(level, namespace, predicate, value))
-        return {"taxomonies": taxonomies}
+        return {"taxonomies": taxonomies}
 
     def run(self):
         if self.data_type == 'file':