Wrong File handling in OTXQuery Analyzer

[sevdog]

Wrong File handling in OTXQuery Analyzer

Request Type

Bug

Work Environment

N/A

Description

In OTXQuery otxquery module the file is mishandled during hash calculation, this may cause various problems:

hash = hashlib.sha256(open(filepath, 'r').read()).hexdigest();

Problems are:

1. file handler is never closed
2. for hash calculation open mode should be binary (rb)
3. if the file is big this operation will be very slow and will use a lot of memory

Possible Solutions

1. The file should be opened using a with statement (aka context manager), as also suggested by python language guidelines

It is good practice to use the with keyword when dealing with file objects

2. The file should be opened in binary mode: rb
3. Reads should be performed per chunk as suggested in this post on SO and also like [django does][(https://docs.djangoproject.com/en/2.0/_modules/django/core/files/base/#File.chunks)
4. Remove trailing semicolon (;)

[3c7]

Thanks for reporting. Fixed in 1.15.2.