Update Elasticsearch analyzer with unix format #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah we noticed that happened when we're moving the code around from our Windows systems :) Somehow we still managed to push out the DOS code by accident. This is a great PR. Thank you! |
|
@nadouani is it ready for merge? Sorry for pinging/bothering you, but I am afraid I am new here and still not sure who maintains this... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
elk.pyis in DOS format and is causing issues when we import and try to run the analyzer:bash: ./elk.py: /usr/bin/env python3^M: bad interpreter: No such file or directoryWe have resolved this issue by doing the following:
vim elk.pyand:set ff=unixSince we are copying the analyzers from this repo, the analyzer gets reverted on restart.