Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summary for ip addresses and resolutions #1205

Closed
wants to merge 5 commits into from
Closed

Fix summary for ip addresses and resolutions #1205

wants to merge 5 commits into from

Conversation

TheOnlyTermin
Copy link
Contributor

Fix for summary report not working and resolutions report not working.

Fixed following bugs:

@jeromeleonard jeromeleonard changed the base branch from master to develop August 1, 2023 08:11
@jeromeleonard jeromeleonard added this to the 3.3.0 milestone Aug 1, 2023
@jeromeleonard jeromeleonard self-requested a review August 1, 2023 08:11
@jeromeleonard jeromeleonard added category:bug Issue is related to a bug scope:analyzer Issue is analyzer related priotiry:high labels Aug 1, 2023
not related to the fix in VirusTotal
not related to the fix for Virustotal
@jeromeleonard
Copy link
Contributor

Not sure resolution(s) short report should be allowed to have another color than blue as this is just an information. High number doesn't mean that the observable is malicious as 0 does not mean this is safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure resolution(s) short report should be allowed to have another color than blue. High number doesn't mean that the observable is malicious as 0 does not mean this is safe

@To-om
Copy link
Contributor

To-om commented Aug 8, 2023

This PR has been merged (5ee4c95) manually.

@To-om To-om closed this Aug 8, 2023
@TheOnlyTermin TheOnlyTermin deleted the fix-virustotal-resolutions branch August 18, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Issue is related to a bug priotiry:high scope:analyzer Issue is analyzer related
Projects
None yet
4 participants