-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splunk Analyzer #142
Splunk Analyzer #142
Conversation
Hey @BrevilleBro, thank you very much for providing the Splunk analyzer. Unfortunately, it does not work with Python 3 - also owed by the splunk module itself which is not Python 3 compatible. We'd like to have all Analyzers working with Python 3, so maybe we can find a solution using some community forks of the original splunk-sdk package. |
There is an issue at the original splunk-sdk-python repository regarding Python 3 support where users also linked their forks which are ported to py3. We could give https://github.com/tltx/splunk-sdk-python/ a try. |
Hi @3c7, I am hesitant to use community forks, however, if Python3 compatibility is a must it may be necessary to do so. |
Either that or waiting for #171. Generally we would like to use Python 3 for all Analyzers and work towards that with the ones that are already released. Best would be if the splunk team decides to use some compatibility package like six to support Python 2 and 3 - but that won't happen, I guess. |
Hi @BrevilleBro as per splunk/splunk-sdk-python@6899980 the offical library now has python 3.5 support. I've tested it with your code and it works. The only other change required to support python3 is to call urllib's quote_plus method from urllib.parse.quote_plus. I can PR if you want me to. |
Hi everyone, hi @3c7 , |
finally decided to merge #534 which is an updated version of this one. |
No description provided.