Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splunk Analyzer #142

Closed
wants to merge 1 commit into from
Closed

Conversation

BrevilleBro
Copy link

No description provided.

@saadkadhi saadkadhi added scope:analyzer Issue is analyzer related status:pr-submitted labels Dec 13, 2017
@3c7
Copy link
Contributor

3c7 commented Dec 28, 2017

Hey @BrevilleBro, thank you very much for providing the Splunk analyzer.

Unfortunately, it does not work with Python 3 - also owed by the splunk module itself which is not Python 3 compatible. We'd like to have all Analyzers working with Python 3, so maybe we can find a solution using some community forks of the original splunk-sdk package.

@3c7
Copy link
Contributor

3c7 commented Dec 28, 2017

There is an issue at the original splunk-sdk-python repository regarding Python 3 support where users also linked their forks which are ported to py3. We could give https://github.com/tltx/splunk-sdk-python/ a try.

@nadouani nadouani requested a review from 3c7 December 29, 2017 10:47
@BrevilleBro
Copy link
Author

Hi @3c7, I am hesitant to use community forks, however, if Python3 compatibility is a must it may be necessary to do so.

@3c7
Copy link
Contributor

3c7 commented Jan 25, 2018

Either that or waiting for #171. Generally we would like to use Python 3 for all Analyzers and work towards that with the ones that are already released.

Best would be if the splunk team decides to use some compatibility package like six to support Python 2 and 3 - but that won't happen, I guess.

@axpatito
Copy link

axpatito commented Apr 9, 2018

Hi @BrevilleBro as per splunk/splunk-sdk-python@6899980 the offical library now has python 3.5 support. I've tested it with your code and it works.

The only other change required to support python3 is to call urllib's quote_plus method from urllib.parse.quote_plus.

I can PR if you want me to.

@LetMeR00t
Copy link
Contributor

Hi everyone, hi @3c7 ,
Do you still need help on this ? I can provide you the fixes of the concerning code here if you want as I'm using both Cortex and Splunk.

@jeromeleonard jeromeleonard changed the base branch from master to develop August 6, 2020 14:40
@jeromeleonard
Copy link
Contributor

finally decided to merge #534 which is an updated version of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants