-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URLhaus analyzer #227
Add URLhaus analyzer #227
Conversation
Hey @ninoseki, thanks for your contribution. It would be great to implement caching, so urlhaus/abuse.ch is queried only once even if analyzing lots of observables in the same time. For an example how to implement caching, you can take a look at the Tor analyzers available. If you're feeling not familiar with implementing caching, I will implement it if I find some time. |
Thank you for the advice. |
@3c7 how is this? |
@ninoseki Damn, I'm sorry. I thought you're working on the csv export data (their API, basically) from URLHaus. That's why I wanted to have some kind of caching mechanism added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution.
This analyzer, while very good, requires We will have sadly to postpone it to another release after modifying the code to use the CSV export from URLhaus or have some kind of Thanks! |
@saadkadhi Oh, it’s absolutely my fault. Let me re-implement the analyzer without |
Referencing to #226, I've created a URLhaus analyzer.
Could you please check it?