Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/urlhaus analyzer #285

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Feature/urlhaus analyzer #285

merged 2 commits into from
Jul 2, 2018

Conversation

ninoseki
Copy link
Contributor

@ninoseki ninoseki commented Jun 9, 2018

@3c7 I’m so sorry for missing that API.(#271)
But I’m still sticking to the scraping because of these reasons:

  • We could combine the 2 CSV exports results but it’s a little bit complex.
  • When dealing with CSV, we should implement matching code to multi-fields. It’s also a little bit complex.

@jeromeleonard jeromeleonard added this to the 1.11.0 milestone Jun 26, 2018
@jeromeleonard jeromeleonard added the scope:analyzer Issue is analyzer related label Jun 26, 2018
@3c7 3c7 merged commit ba2a8fe into TheHive-Project:feature/urlhaus-analyzer Jul 2, 2018
@ninoseki
Copy link
Contributor Author

ninoseki commented Jul 2, 2018

@3c7 @jeromeleonard Thanks!

@ninoseki ninoseki deleted the feature/urlhaus-analyzer branch July 2, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:analyzer Issue is analyzer related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants