Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella analyzer: query_limit: error if no data provided #479

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

siisar
Copy link
Contributor

@siisar siisar commented Apr 26, 2019

query_limit gets error if no data provided. The default value 20 must be the second parameter, not the third (currently the default is None, and the str(None) is cracking)

query_limit gets error if no data provided. The default value 20 must be the second parameter, not the third (currently the default is None, and the str(None) is cracking)
@siisar siisar changed the title query_limit: error if no data provided Umbrella analyzer: query_limit: error if no data provided Apr 26, 2019
@3c7 3c7 added scope:analyzer Issue is analyzer related category:bug Issue is related to a bug status:pr-submitted labels Jun 16, 2019
Copy link
Contributor

@LaZyDK LaZyDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended in TheHive 3.4.0-1 and Cortex 3.0.0-1.

@jeromeleonard jeromeleonard changed the base branch from master to develop November 17, 2019 13:54
@jeromeleonard jeromeleonard self-assigned this Nov 17, 2019
@jeromeleonard jeromeleonard merged commit 00ef849 into TheHive-Project:develop Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Issue is related to a bug scope:analyzer Issue is analyzer related status:pr-submitted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants