Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving to AbuseIPDB API v2 #702

Closed
wants to merge 5 commits into from

Conversation

shortstack
Copy link
Contributor

@shortstack shortstack commented Feb 21, 2020

API v1 has been sunset, according to the responses from the API, updated to use v2

@shortstack shortstack closed this Feb 21, 2020
@shortstack shortstack reopened this Feb 21, 2020
@shortstack
Copy link
Contributor Author

question--do the docker images for docker-enabled cortex pull from this repo when they're deployed? in this case, we can't test analyzer changes locally if docker analyzers are enabled :( unless i'm missing something

going back to a process analyzer (vs docker) in application.conf requires refreshing/disabling/reenabling analyzers and still seems to throw json errors when i try to go back to non-docker and run analyzers

@dadokkio
Copy link
Contributor

Hi, I wasn't aware of your pull request so I made a similar one with a different approach.
In my case I removed the reports information and I've just counted categories and submitter nationalities.
This is an example view of my approach:
image

Not sure if my approach is ok, we didn't use abuseipdb so I tried to collect from hundreds of report information I found useful.

Meanwhile, I've also tested your code and it's working properly.
The only missing piece are templates for thehive. Are you able to add those to your pull?

@shortstack
Copy link
Contributor Author

hi @dadokkio,

thanks for responding. i updated it only to do what it was already doing, but with the new API configuration. regarding the report template, i will add. thank you! :)

@dadokkio
Copy link
Contributor

Perfect, I just made one small fix 944afb6
to render categories name in template.
image
If that is ok I'm going to merge your pull.

@shortstack
Copy link
Contributor Author

awesome! thank you!! :)

@dadokkio
Copy link
Contributor

merged with #719

@dadokkio dadokkio closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants